#29800 Model patch of an existing database fails when a class gains a generalization and overrides its attributes in the same change

enhancement

major

#29659

TL Views: Popover-Element mit beliebigem Inhalt an einer auslösenden Schaltfläche

#29713

TL Views: a user cannot hide a tile of a <dashboard> and add it again later

#29755

React-UI: Auswahl in Objektlisten (<object-list selection>) – Karten direkt anwählbar

#29756

React view table: Excel export (parity with classic TableComponent) and generic download view action

#29757

React view table: show row count (total / filtered / selected) like the classic table

#29776

TL Views: Einheitliches Drag & Drop für Tabellen, Baum-Tabellen, Bäume und Kanban-Boards mit mehreren Drop-Operationen, Drop-Positionen und Drag-Arten

#29782

Concept: Discover right for the model based security (filtered object sources, masked form fields)

#29785

OpenAPI server: request bodies are not validated against the declared schema

#29786

MUI: Avatar (TLAvatar) mit Material UI darstellen

#29787

React UI: Atomare Bausteine (Schaltflächen, Menü-Auslöser, Checkboxen, Eingabefelder, Chips, …) sehen überall gleich aus und lassen sich durch eine Komponentenbibliothek (z.B. Material UI) ersetzen

#29797

XML import into existing data: resolve IDs against existing objects, skip known subtrees, optional references, language and variables from the input

#29799

Form dependencies: derived fields do not follow edited values; Java script functions cannot report what they read to the ScriptTracer

#29811

TL Views: a <button> ignores the display mode of its command and always shows icon and label

#29812

TL Views: a table column declares its own comparator; enumeration columns follow the enumeration's order

#29814

TL Views: no supported way for a server-side background source (a bus listener) to push a channel value into a view; only <start-job> does it through internal API

#29815

TL Views table: no per-row CSS class (a row cannot be marked as changed, stale or own)

#29816

TL Views table: a <computed-column> cannot be hidden by default (shown only through the column chooser)

#29821

Design System wave 3b: table, tree, column selection and text read the design system package

#29825

Design System: column selection of the React table – grouping as one select, checkbox first, visible and hidden columns apart

#29829

TL Views: Beschreibbarer Kanal, der aus anderen Kanälen vorbelegt wird

#29830

Transaction monitor: Select a time range or a revision range instead of a single day.

#29836

Design System wave 4a: dialog, window, drawer, snackbar and notice bar read the design system package

#29840

Persistent object wrapper hierarchy: remove dead and duplicated code, move stateless behavior into interface defaults, replace class identity checks

#29849

Configuration: an encrypted property value that is not a valid encrypted value is silently "decrypted" to garbage instead of being rejected

#29854

PowerPoint-Präsentationen aus TL-Script erzeugen: deklarative Folienbausteine, Export in eine Firmenvorlage, Analyse von Vorlagen

#29858

Privileged TL-Script functions: authorize a configured script as a whole by a command group on a computed security object

#29859

React-Einfachauswahl: Die aktuell gewählte Option fehlt in der Optionsliste

#29866

Design System wave 4b: app shell, app bar, sidebar and bottom bar read the design system package

#29870

Design System wave 4c: layout containers read the design system package

#29907

Entwicklerkommandos und Skript-Rekorder außerhalb des Produktivmodus für alle Benutzer

minor

#28605

Möglichkeit zum Download eines aufgezeichneten Skripts

#28995

Spaltenfilter sollte Comparator der Spalte bei Sortierung der Optionen berücksichtigen

#29801

TL Views: the split of <adaptive-detail> is configurable (size, unit, min-size on <selector> and <detail>; drawer width as drawer-size)

#29805

TL Views: a <value-input> is declared like a model attribute (mandatory, annotations) - a mandatory enumeration input offers no "no value" option

defect

critical

#29784

OpenAPI server: basic authentication of a technical user accepts an empty password when the configured password is empty (e.g. unset environment variable)

#29823

HistoryCompaction: Löschen von REVISION/REVISION_XREF und Umschreiben der Revisionsbereiche in je einer Transaktion lässt die Datenbank explodieren

major

#29580

RowSourceObserver: a disposed observer is still notified and throws NPE (_scope null) from DerivedViewChannel and GlobalModelEventForwarder

#29783

TLScriptFunctions: a script function is bound to an arbitrary overload of the same name, including a private one

#29788

Configuration: the error for an undecodable encrypted property echoes the value (e.g. a plain-text password) into the log

#29789

tl:generate-java fails on the first build after a TopLogic version change: it neither resolves the engine web fragments nor reads the project's own model sources

#29791

TL Views table: the row activation button runs the activation command without selecting its row, so commands reading the selection channel see another row (wrong breadcrumb label)

#29792

TL Views: a closed dialog (and a left tile-stack frame) stays visible for 1 s unless the application ships its own exit animation - move the demo's animations into the engine

#29800

Model patch of an existing database fails when a class gains a generalization and overrides its attributes in the same change

#29806

WrapperGenerator: every top-level class of a module with a singleton extends StructuredElement (regression of #26716)

#29807

WrapperGenerator: classifier constants of two enumerations collide, the generated factory does not compile

#29808

TL Views: the <on-submit> command of a text or number <value-input> runs on Enter only, not when the field is left with a changed value

#29810

TL Views: the selection channel of a <tree> keeps an object deleted in another view, and scripts over it fail

#29813

TL Views: a <tree> does not react to a change of an object it does not display yet, so a node that becomes a child of a shown node does not appear

#29822

CompactHistoryTask: Wartungsfenster bleibt nach dem Lauf aktiv, Task-Ende geht im Neustart der Persistenzschicht verloren

#29824

TL Views table: "Standard wiederherstellen" in the column selection drops a declared group-by (and does not restore the declared sort)

#29837

TestCompileJSPs modifies the module's source webapp and breaks concurrently running scripted tests of the same module

#29838

ClusterManager: a database connection that failed in a cluster transaction is returned to the pool and keeps failing every refetch

#29846

Changing the type of a column with content fails on Oracle (ORA-01439) and of an indexed column on MS SQL Server

#29848

ReportQueueTest.testAddJob fails sporadically: the queue thread may process the job before the test checks that it is queued

#29871

TestZipper.testEmptyFolder fails depending on the order in which the file system lists a folder

#29878

React UI does not react behind a proxy that buffers or refuses the window event stream

minor

#29766

TL-Script add() wirft UnsupportedOperationException bei Multi-Referenz auf transientem Objekt

#29804

XML import: line and column of a message location are formatted with a thousands separator ("line 4,433")

#29809

TL Views: a <value-input type="tl.core:Binary"> shows the file name as text instead of the binary field (no upload, no download)

task

minor

#29790

Upgrade guide 7.11 to 8.0: add the Maven >= 3.8.9 requirement, state that 7.10.x applications can follow it, and point to it from the release notes

#29793

Developer docs: recipe for an application-defined primitive type whose display depends on the owning object (custom datatype, value class, type-level storage, label provider, input control)

defect

major

#29800

Model patch of an existing database fails when a class gains a generalization and overrides its attributes in the same change

Model

Adding a generalization to an existing class and, in the same model change, overriding attributes of the new generalization cannot be applied to an existing database (TL 8.0.0-alpha10): the automatic model patch at startup applies the overrides before the generalization.

Reproduction

Start an application with a class m:B extending tl.model:TLObject and an interface m:A with a property x; create some data.
Change the model: m:B gets the generalization m:A and overrides x` (<property name="x" override="true" …>`, e.g. to annotate a label or options).
Start again with the existing database.

Expected: the patch adds the generalization and then the override. Actual: startup aborts with

Override failed. m:B#x is declared to be an override, but is not overriding anything (m:B extends tl.model:TLObject.)

A fresh database is set up correctly with the same model.

Seen in E-Home: ehome.physical:ParameterSetting became an ehome.operational:ParameterValue and overrode number, decimal and text ("Override failed. ehome.physical:ParameterSetting#number is declared to be an override, but is not overriding anything (ehome.physical:ParameterSetting extends tl.model:TLObject.)"). The local database had to be reset. The overrides were later removed, so the app no longer depends on this.

Expected fix: the model patch orders the changes so that new generalizations are applied before attribute overrides of the same class (or applies the patch of a class in two passes).

Lösung

Ursache. Die Elemente eines Modell-Patches werden vor dem Anwenden nach einer festen Priorität sortiert (Priority in com.top_logic.element.model.diff.apply). Dort stand das Anlegen überschreibender Attribute (CREATE_TYPE_PART_OVERRIDE) vor dem Hinzufügen von Generalisierungen (CREATE_OR_MOVE_GENERALISATION). Ein überschreibendes Property an einer bestehenden Klasse wird beim Anwenden sofort angelegt und dabei gegen die aktuellen Generalisierungen der Klasse geprüft (ModelResolver.createProperty), so dass die Prüfung fehlschlägt, wenn die Generalisierung erst durch ein späteres add-generalization hinzukommt. Referenzen und die Attribute neu angelegter Typen werden erst in complete() angelegt und sind nicht betroffen.

Änderungen.

CREATE_OR_MOVE_GENERALISATION wird vor CREATE_TYPE_PART_OVERRIDE (direkt nach CREATE_TYPE_PART) angewendet. Die SQL-Migrationsprozessoren werden in Anwendungsreihenfolge erzeugt, so dass auch dort add-generalization vor dem Anlegen des Overrides steht.
Ein bereits vorhandenes eigenes Attribut, das durch eine neue Generalisierung zu einer Überschreibung wird (bzw. durch Entfernen einer Generalisierung keine mehr ist): isOverride() ist aus der gespeicherten Definition (definition-Referenz) abgeleitet; das persistente Modell (auf dem der Start-Patch direkt angewendet wird) berechnet sie beim Ändern der Generalisierungen nicht neu. ApplyModelPatch berechnet beim Anwenden von add-generalization / remove-generalization die Definitionen der lokalen Attribute der Klasse und ihrer Spezialisierungen neu und erzeugt für jedes geänderte Attribut einen mark-override-Migrationsprozessor (MarkTLTypePartOverride). Der Prozessor erhält die Option copy-values: beim nachträglichen Markieren behält das Attribut seine eigenen Eigenschaften (mandatory usw.), beim Anlegen eines Overrides werden sie wie bisher von der Definition übernommen; ist definition das Attribut selbst, wird es als eigene Definition (keine Überschreibung) markiert.
Dabei gefunden: Im transienten Modell (TLClassImpl) wurden die Definitionen beim Hinzufügen einer Generalisierung berechnet, bevor die Generalisierung in der Liste stand (ObservableList.beforeAdd), so dass ein Hinzufügen die Definitionen nie aktualisierte (das Entfernen schon). ObservableList hat nun einen afterAdd-Hook, TLClassImpl berechnet die Definitionen darin.
Tests: TestModelPatch (transient, persistent direkt gepatcht sowie über die SQL-Migration) für beide Fälle in beide Richtungen, TestTLModelImpl für das transiente Modell.