#29292 Clearly mark generator errors as errors in the build output

enhancement

major

#29064

TL-Script: Optimization of database queries with parameters

minor

#29292

Clearly mark generator errors as errors in the build output

defect

minor

#29304

Replacement value attribute is not applied correctly in transient objects

#29305

Error when creating a configured TL script function

#29314

Error when rolling back changes

#29318

ChangeSet analysis fails with unversioned types

enhancement

minor

#29292

Clearly mark generator errors as errors in the build output

ModelSystem

Problem

If the Java binding generation fails (Maven-Goal tl-maven-plugin:generate-java), the build ends with:

[ERROR] ... generate-java (generate-binding) ... failed: InvocationTargetException: Aborting due to previous errors

Although the generator outputs the actual cause beforehand, it is not recognizable as an error:

SyserrProtocol outputs error and info messages unmarked(System.err.println and System.out.println respectively). They differ only in the stream - invisible in the merged Maven console. Example: No java implementation package found for module 'X'. looks like a harmless info line.
grep-/Log-Tooling cannot find these errors via an [ERROR] pattern.

Additionally a real bug: WrapperGenerator.generateMessages() reports errors when generating a messages file only via the Log4j logger facade. As a result, no hasError is set in the log - the generator continues to run and reports success even though a file is missing.

Solution

SyserrProtocol: add a Maven-style prefix to each line - [ERROR] for error/fatal, [INFO] for info output. BufferingProtocol remains untouched (it already separates info/error structurally; its data API must not be falsified).
WrapperGenerator.generateMessages(): Change Logger.error(...) to _log.error(...) so that the error is recognized and leads to a correct abort.

Affected files

com.top_logic.basic/src/main/java/com/top_logic/basic/SyserrProtocol.java
com.top_logic.element/src/main/java/com/top_logic/element/model/generate/WrapperGenerator.java