#25859 JavaScript error when expanding nodes in TreeTables

Enhancement

Major

#26542

yFiles: onDoubleClick and context menu on node

#26563

Checking dependencies for security vulnerabilities

#26620

Drag and drop with multiple selection

#26696

Increase minimum Java version to 11

#26715

Uniform multi-selection display for grid and tables

#26719

WrapperGenerator: Maven plugin for wrapper generation

#26726

Code" data type

#26732

Layout editor: alternative views for different model types

#26739

WrapperGenerator: Typed factory methods and addXxx(), removeXxx()

#26746

Model: Password attributes

#26761

TL-Script: contextPath() function

#26772

List-valued attributes with primitive type

#26775

Automatic translation from I18NConstants

#26811

Kafka & TL-Sync swap log messages to own file

#26816

Add Kafka and TL-Sync status to monitor page

Detail

#24564

Creating ScriptRecorder templates not in the deploy folder

#26215

TL-Doc: Plugin for templates

#26703

Update MSSQL JDBC driver to version 10.2.0.jre11

#26707

API consistency checking tool

#26708

Check for missing translations of the I18NConstants in the nightly build.

#26712

Maven configuration for calling normalize layouts

#26722

TL-Maven plugin: Goal `translate` with encrypted server passphrase for DeepL

#26723

Redefine table column for primitive model attribute (simple)

#26728

CodeEditorControl should not write ACE editor for invisible fields

#26734

Schema editor: column selection when defining key attributes

#26747

JavaDoc: Warning for CameCase content inside <p>-tags in

#26752

Removing the tl-help module

#26764

Model editor: improve the design of the context menu

#26765

Model Editor: Extend context menu with GoTo Definition

#26766

Model Upgrade: Make-Abstract and Make-Concrete

#26799

Better loading cursor support for multiple long-running GUI actions

#26814

Faster resolving of files in FileManager (without Files.exists(...))

#26815

KBDataProducerTask should react on stop request of the scheduler

#26822

Migration: DB schema update after migration

#26838

Reduce selection for SingleSelectionModel if necessary

#26841

Migration: moving instances to another table

Nice to have

#26706

Better logging when building the App-WAR

#26737

Eclipse Maven settings: current TL version as minimum version for plugin exclude

#26738

Archetype: Avoid fully qualified module names

Bugfix

Critical

#26850

Enums of a module disappear when creating and deleting enums in this module

Major

#25761

Race Condition in TL-Sync in case of model changes, e.g. new TLClassifier

#26612

Invalid session revision for multiple threads

#26716

WrapperGenerator: derivation of StructuredElement not for all classes of a module

#26790

Error loading objects with long texts with H2

#26791

Knowlege Base: Error when updating validity periods when reloading object data

#26802

Migration scripts are not executed

#26808

Replay migration with H2 fails with long CLOB and BLOB values

#26809

Replay migration fails due to access to read-only columns

Detail

#25343

Missing filename check with multi-upload

#25834

Error with system without "maintenance pages

#25859

JavaScript error when expanding nodes in TreeTables

#26379

Replay migration fails because DependencyInjection does not take place

#26438

Checkbox to select all entries cannot be clicked

#26465

Module names with parts from digits allowed but not working

#26555

Bookmarks from TL-Doc always use the internal address

#26557

TL-Doc: Highlighting of code blocks leads to RegEx errors

#26577

Import of documentation does not work on Maven workspaces

#26602

No admin button in Modern theme

#26619

Inlining a file in LayoutModelProcessor broken

#26624

Incremental updates in TreeGrid do not always work

#26635

Remove dependency on apache-mime4j-0.3.jar

#26637

Raise dependency pac4j to version 5.3.1

#26638

Raise dependency H2 to version 2.1.210

#26639

Remove Ext Module for Jetty

#26640

Remove dependency openxml4j

#26641

Update Jetty to 9.4.45.v20220203

#26645

TestComponentConfiguration should not test templates

#26646

Udate POI to version 5.2.2

#26647

Update jsoup to version 1.14.3 and guice to version 5.1.0

#26649

Update commons-io to version 2.11.0

#26660

Remove TL Remote

#26680

Multiselection support in Tree, Table and TreeTable

#26694

replace itext 2.1.7 with openpdf 1.3.27

#26698

Raise MySQL Connector to version 8.0.27

#26699

Collapsing the selection changes the selection in TreeGrids

#26704

Dependency Analysis Tool: No Duplicate Classes in ClassPath

#26710

ModelBuilder for Services view inserts user sessions into the table

#26711

ACE Editor and requirejs define the global variable require

#26717

JavaDoc writes outside the module by default

#26720

CodeEditorControl is to report client-side errors of the ACE editor

#26724

Meta-model: access to the index of a classifier

#26725

Schema editor: error when saving

#26727

Missing adjustment of (default) selection after tree update

#26731

Model Editor: Delete in detail view removes wrong diagram element

#26735

Form editor: crash if attribute no longer exists

#26736

Double configuration of the description of a TLType

#26744

Post-create action in trees does not work with in-app commands

#26748

Insufficient quoting when writing JavaScript

#26757

Inconsistent API of StructuredElement

#26758

Model editor loses selection during relayout

#26760

Project Demo: Use H2 database config as local default.

#26763

TL-Doc: Copying old help documentation does not work

#26767

Model export writes resource files to wrong module

#26768

Parents are not always expanded after selection change

#26770

Model Editor: Error during further editing after deleting element

#26771

NPE when filtering all threads in the thread monitor

#26773

TL script: Self-expression in concat() is not taken into account

#26774

TL script: Error message when sublist() is called with too large index

#26783

WYSIWYG CSS uses variable defined in com.top_logic.icons

#26786

Launch-Configs still reference Java-8 VM

#26795

Data migration for ticket #25881 and #26398

#26800

Scripting: Record StructuredElement with arbitrary singleton root

#26803

KnowledgeBaseRuntimeException when accessing deleted reference

#26804

No consistent deletion of model elements during model upgrade

#26806

Script recorder: record branch and revision only if necessary

#26812

Subtree update of an invisible root node faulty

#26827

No error message when accessing foreign key references if foreign key cannot be resolved

#26842

Scripting recorder: Playback of multi-selection faulty

#26845

NPE in the translation service if no network connection is available at startup.

#26848

Document management does not work in non-versioning system

#26849

Maps of ConfiguredInstances should keep order

#26854

Tab delete of a legacy tabbar is not recorded

#26855

Missing dependency DynamicComponentService -> SafeHTML

Nice to have

#26792

Scripting: Assertions try to access invisible columns

Bugfix

Detail

#25859

JavaScript error when expanding nodes in TreeTables

TreeTable

In the following situation a javascript error occurs:

Two tables X` and `Y are visible. Y is a tree table that is defined as a drop target.

Now there is an event that causes X` to change the selection and `Y to change the expand state of a node.

Then there is the javascript error:

2021-03-30 10:50:15,149 ERROR [qtp1638335699-46]: base.services.simpleajax.AJAXServlet$AJAXLogHandler - Client-side message: Uncaught JavaScript exception (exception: 'TypeError: nodesArray is null', component: 'masterFrame', source: 'http://localhost:8080/pvm/servlet/LayoutServlet/w19502b3c85120aaa-f8697ac5a0fdad1', layout: 'masterFrame.xml', session: node01330x7z95lzb618k37obsjewrs2, UserAgent [Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:86.0) Gecko/20100101 Firefox/86.0])

Cause

The tree table Y redraws itself as the unfold state of a node is changed.

Y` is drop-target, therefore the HTML-dom-parent `D of the table is a DIV without ID (the tl:ContentRenderer writes an anonymous DIV) which is re-layouted.

Because X also has an update there are 2 nodes that need to be re-layouted.

Now there is javascript code that analyzes the set of nodes M` to layout to layout only nodes that have no inner nodes to layout. This is done by looking if there is a DOM ancestor in M` for a node in `M`. This is done by looking if there is a node in `M with the same ID for an ancestor.

M` contains the anonymous DIV (without ID) `D written by the tl:ContentRenderer. Of course there is a predecessor of this DIV with the same, namely no, ID. The algorithm thinks there is an ancestor in M` and ignores `D. All other nodes to layout are also considered by the algorithm as children of `D`, so they are ignored.

The consequence is that (supposedly) no nodes have to be laid out. Now a bug in the LinkedHashMap (in JS) strikes which says: The values of an empty map are null. So a null access takes place.

Test

An automatic test is not possible, because the problem is in the JavaScript code.
Since the problem can otherwise only be reproduced with additional views, which are not technically useful, a patch must be applied.
Apply the following patch:

{{#!patch ### Eclipse Workspace Patch 1.0 #P com.top_logic Index: src/com/top_logic/layout/layoutRenderer/ContentRenderer.java =================================================================== --- src/com/top_logic/layout/layoutRenderer/ContentRenderer.java (revision 307602) +++ src/com/top_logic/layout/layoutRenderer/ContentRenderer.java (working copy) @@ -94,7 +94,7 @@ businessComponent.writeDebugHeader(out); }

if (dropEnabled(contentControl)) {

+ if (true || dropEnabled(contentControl)) { out.beginBeginTag(DIV); out.beginCssClasses(); out.append("lcViewport"); }}

In the demo in the DemoTypes structure under the root node have two nodes generated.
Go to the following view: Technical Demo > Layout Framework#1 > Forms > In-App Drag and Drop.
In the TreeGrid expand the first of the generated nodes and drag the A1 into the TreeTable onto the second generated node.
No error must be logged.
All displayed views must look correct.
- In particular, the footer must be displayed at the bottom of all displayed tables and not somewhere in the upper right corner directly below the table header next to the column contents.