Major
Nice to have
Bugfix
Major
The WebFolderUIFactory is to be made into a module.
Additionally a configuration option for the BreadcrumbRenderer should be implemented. So you can configure for example if the WebFolder should use icons in the breadcrumb or not. This is necessary by #23183.
Test
No test: Converting a singleton to a module does not require a test.
Code Migration
DefaultBreadcrumbRenderer.Config.getBreadcrumbContentRenderer() has been migrated from BreadcrumbContentRenderer to BreadcrumbContentRenderer.Config. So the configuration no longer contains the instance directly, but the configuration.
- DefaultBreadcrumbRenderer.Config.setBreadcrumbContentRenderer(...) has been deleted. DefaultBreadcrumbRenderer.setBreadcrumbContentRenderer(...) can be used instead.
The WebFolderUIConfig class has been dropped. Its config options are now part of WebFolderUIFactory in the typed configuration:
<config service-class="com.top_logic.common.webfolder.ui.WebFolderUIFactory"> <instance class="com.top_logic.common.webfolder.ui.WebFolderUIFactory" provide-zip-download="true" zip-download-file-name-provider="com.top_logic.common.webfolder.ui.commands.ZipDownloadLabelProvider" zip-download-size-limit="1024" zip-folder-name-provider="com.top_logic.common.webfolder.ui.commands.ZipFolderNameProvider" > <breadcrumb-renderer> <contentRenderer resource-provider="com.top_logic.mig.html.NoImageResourceProvider"/> </breadcrumb-renderer> </instance> </config>
Presumably, no project has come in contact with this class directly. Therefore, the migration instructions are concise. If there are nevertheless such cases and these cannot be migrated themselves, simply report to me.
- Search for WebFolderUIConfig in XML files. Change the configurations accordingly. (See changesets of this ticket.)
- Search for WebFolderUIConfig in Java files.
- ReplaceWebFolderUIConfig.INSTANCE with WebFolderUIFactory.getInstance().
- ReplaceisZipDownloadActive() with getProvideZipDownload().