major
nice-to-have
defect
major
The WebFolderUIFactory is to be turned into a module.
In addition, a configuration option for the BreadcrumbRenderer will be added. This will allow users to configure, for example, whether WebFolder should use icons in the breadcrumb trail or not. This is required by #23183.
Test
No test: Converting a singleton into a module does not require a test.
Code Migration
DefaultBreadcrumbRenderer.Config.getBreadcrumbContentRenderer() has been changed from BreadcrumbContentRenderer to BreadcrumbContentRenderer.Config. The configuration therefore no longer contains the instance directly, but rather the configuration itself.
- DefaultBreadcrumbRenderer.Config.setBreadcrumbContentRenderer(...) has been removed. Instead, DefaultBreadcrumbRenderer.setBreadcrumbContentRenderer(...) can be used.
The WebFolderUIConfig class has been removed. Its configuration options are now part of WebFolderUIFactory in the typed configuration:
<config service-class="com.top_logic.common.webfolder.ui.WebFolderUIFactory">
<instance class="com.top_logic.common.webfolder.ui.WebFolderUIFactory"
provide-zip-download="true"
zip-download-file-name-provider="com.top_logic.common.webfolder.ui.commands.ZipDownloadLabelProvider"
zip-download-size-limit="1024"
zip-folder-name-provider="com.top_logic.common.webfolder.ui.commands.ZipFolderNameProvider"
>
<breadcrumb-renderer>
<contentRenderer resource-provider="com.top_logic.mig.html.NoImageResourceProvider"/>
</breadcrumb-renderer>
</instance>
</config>
Presumably, no project has come into direct contact with this class. Therefore, the migration instructions are kept brief. If there are such cases after all and they cannot be migrated on your own, simply contact me.
- Search for WebFolderUIConfig in XML files. Update the configurations accordingly. (See the changesets for this ticket.)
- Search for WebFolderUIConfig in Java files.
- ReplaceWebFolderUIConfig.INSTANCE with WebFolderUIFactory.getInstance().
- Replace `isZipDownloadActive() ` with ` getProvideZipDownload() `.