enhancement
major
minor
major
minor
minor
#29664
TL Views: the form's Edit, Save, Cancel and Apply commands are labelled with a trailing period ("Bearbeiten.", "Speichern.")
Problem
The edit-mode commands of a view-layer <form> show their labels with a trailing period: "Bearbeiten.", "Speichern.", "Abbrechen." (en: "Edit.", "Save.", "Cancel."). Visible as button text, tooltip and accessible name (TL Development app, ticket page, snapshot build 42).
Cause
com.top_logic.layout.view.I18NConstants declares the keys with sentence JavaDoc:
/** @en Edit. */ public static ResKey FORM_EDIT; /** @en Save. */ public static ResKey FORM_SAVE; /** @en Cancel. */ public static ResKey FORM_CANCEL;
and likewise FORM_APPLY ("Apply."). The doclet takes the @en text verbatim, so messages_en.properties carries Edit. and the DeepL seed Bearbeiten. etc.
Expected
Command labels without a period (@en Edit, @en Save, @en Cancel, @en Apply) and the German entries corrected by hand (Bearbeiten, Speichern, Abbrechen, Anwenden). Worth a grep over the other I18NConstants of com.top_logic.layout.view / com.top_logic.layout.react for further command or button labels ending in a period.
Lösung
The @en texts of FORM_EDIT, FORM_APPLY, FORM_SAVE and FORM_CANCEL no longer end in a period; messages_en is regenerated, messages_de reads Bearbeiten, Anwenden, Speichern, Abbrechen.
A scan of all I18NConstants in com.top_logic.layout.view and com.top_logic.layout.react found no further command or button labels with a trailing period; the remaining short texts ending in a period are messages (log/audit entries, errors, empty-state hints), for which the sentence form is correct.