enhancement
Features of the theme editor
- Create/delete theme
- Insert/create/edit/delete CSS file
- Edit theme variables in theme-settings.xml (icons, CSS variables), redefine (inherited), create, delete.
- Upload/delete theme icons
Open points
MergeThemeConfigs is located in the theme editor package but is accessed from the general base-build.xml.If a variable is redefined in theme X` that was previously inherited from theme `Y`, this variable is incorrectly saved back to theme Y` (instead of being created in theme `X` ).Create variable- ~~Theme protect - If a `protected` flag is set in the theme.xml` (which cannot be set in the GUI for a new theme or edited for an existing one), then no styles can be created/edited/deleted, no variables can be created/edited/deleted and no icons can be uploaded or deleted for this theme. ~~
Base theme is a mandatory entry when creating a new theme in the GUI. Otherwise, this will inevitably lead to the new theme not working because "mandatory" variables such as MAIN_LAYOUT_CLASS are not assigned.Delete variable / or delete override - reset to default value if it is an inherited variable.Delete style fileDelete icon / or delete override - reset to default value if it is an inherited icon.Make theme properties editable.Double edit button for the theme propertiesBetter "Export theme" and "Import theme" buttons in the menu.After saving theme properties, the theme table loses the selection and selects the first element again. This gives the impression that saving had a strange effect.The "Advanced" option when editing theme properties is not a selection list like when creating a new theme.A cycle test is missing. An incorrect selection/entry crashes the application completely.Variable table should better be a viewport table. The row height must be adapted to the maximum height of the displayed images.Missing I18N for type selection of new theme variablesDialog height for new theme variable much too low.Missing confirmation prompt "Are you sure" when deleting theme variables, deleting themes, deleting style sheets, deleting icons.When saving theme.xml, it is pre-printed but with space instead of tab indentation.The same applies to theme-settings.x ml (wrong indentation).- The maximize button of the theme editor should maximize the complete editor and not only the detail view
Test
- ThemeEditor_Ticket-23854.script.xml
- ThemeEditor_Ticket-23854_SelectAbstractThemes.script.xml